Skip to content

Commit

Permalink
Update UT and GitHub Actions (#472)
Browse files Browse the repository at this point in the history
* Try removing hanging tests

* Try #2

* Try #3

* Try #4

* Try #5

* Try #6

* Try #7

* Try #8

* Try #9

* Try #10

* Revert "Try #7"

This reverts commit 60be578.

* Reapply "Try #7"

This reverts commit 912c0c4.
  • Loading branch information
cyanzhong authored Feb 23, 2024
1 parent 3b0e05f commit 5c85952
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 21 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
working-directory: 'CoreEditor'

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.node-version }}
cache: 'npm'
Expand Down
4 changes: 0 additions & 4 deletions MarkEdit.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
870F17902985775B00003DA7 /* AppKitExtensions in Frameworks */ = {isa = PBXBuildFile; productRef = 870F178F2985775B00003DA7 /* AppKitExtensions */; };
870F17922985775B00003DA7 /* Previewer in Frameworks */ = {isa = PBXBuildFile; productRef = 870F17912985775B00003DA7 /* Previewer */; };
870F17962985775B00003DA7 /* SettingsUI in Frameworks */ = {isa = PBXBuildFile; productRef = 870F17952985775B00003DA7 /* SettingsUI */; };
870FF83A298BD7DC00E4AE99 /* BundleTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 870FF839298BD7DC00E4AE99 /* BundleTests.swift */; };
871A2F4D2A4BD22F0080E3F5 /* RuntimeTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 871A2F4C2A4BD22F0080E3F5 /* RuntimeTests.swift */; };
871C995B2973F1E6003FF3A7 /* AppDelegate+Document.swift in Sources */ = {isa = PBXBuildFile; fileRef = 871C995A2973F1E6003FF3A7 /* AppDelegate+Document.swift */; };
871C995D2973F20E003FF3A7 /* AppDelegate+Menu.swift in Sources */ = {isa = PBXBuildFile; fileRef = 871C995C2973F20E003FF3A7 /* AppDelegate+Menu.swift */; };
Expand Down Expand Up @@ -137,7 +136,6 @@
870F17752985546500003DA7 /* MarkEditCore */ = {isa = PBXFileReference; lastKnownFileType = wrapper; path = MarkEditCore; sourceTree = "<group>"; };
870F178C2985774D00003DA7 /* Modules */ = {isa = PBXFileReference; lastKnownFileType = wrapper; path = Modules; sourceTree = "<group>"; };
870FF837298BD7DC00E4AE99 /* MarkEditMacTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = MarkEditMacTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
870FF839298BD7DC00E4AE99 /* BundleTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BundleTests.swift; sourceTree = "<group>"; };
871A2F4C2A4BD22F0080E3F5 /* RuntimeTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RuntimeTests.swift; sourceTree = "<group>"; };
871C995A2973F1E6003FF3A7 /* AppDelegate+Document.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "AppDelegate+Document.swift"; sourceTree = "<group>"; };
871C995C2973F20E003FF3A7 /* AppDelegate+Menu.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "AppDelegate+Menu.swift"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -338,7 +336,6 @@
870FF838298BD7DC00E4AE99 /* MarkEditMacTests */ = {
isa = PBXGroup;
children = (
870FF839298BD7DC00E4AE99 /* BundleTests.swift */,
871A2F4C2A4BD22F0080E3F5 /* RuntimeTests.swift */,
);
path = MarkEditMacTests;
Expand Down Expand Up @@ -737,7 +734,6 @@
buildActionMask = 2147483647;
files = (
871A2F4D2A4BD22F0080E3F5 /* RuntimeTests.swift in Sources */,
870FF83A298BD7DC00E4AE99 /* BundleTests.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
15 changes: 0 additions & 15 deletions MarkEditMacTests/BundleTests.swift

This file was deleted.

4 changes: 4 additions & 0 deletions MarkEditMacTests/RuntimeTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ import WebKit
import AppKitExtensions

final class RuntimeTests: XCTestCase {
func testExistenceOfAppIcon() {
XCTAssertNotNil(NSImage(named: "AppIcon"), "Missing AppIcon from the main bundle")
}

func testExistenceOfDrawsBackground() {
let configuration = WKWebViewConfiguration()
configuration.setValue(false, forKey: "drawsBackground")
Expand Down

0 comments on commit 5c85952

Please sign in to comment.