Skip to content

Allow Delete key to delete selected nodes and edges#83

Closed
nivedita9009 wants to merge 2 commits into
MarkAStevens04:mainfrom
nivedita9009:fix-delete-key
Closed

Allow Delete key to delete selected nodes and edges#83
nivedita9009 wants to merge 2 commits into
MarkAStevens04:mainfrom
nivedita9009:fix-delete-key

Conversation

@nivedita9009

@nivedita9009 nivedita9009 commented Jun 26, 2026

Copy link
Copy Markdown

Closes #79

πŸ€” Section A - Description

What does this PR do?

This PR adds support for the Delete key in addition to the Backspace key for deleting selected nodes and edges in the ReactFlow editor.

Why?

Previously only the Backspace key could delete selected nodes and edges. This change allows users to use either Backspace or Delete, matching common desktop application behavior.


βœ… Verification

  • Ran the application locally.
  • Selected a node.
  • Pressing Backspace deletes the selected node.
  • Pressing Delete also deletes the selected node.
  • Existing functionality continues to work.

πŸ”Ž Quick Self Check

  • I tested my changes locally.
  • My changes are limited to this feature.
  • I did not introduce unrelated changes.
  • I followed the project's coding style.

πŸ“œ BioBuilder Contributor License Agreement

  • I confirm that I wrote this code myself and agree to the project's Contributor License Agreement.

@MarkAStevens04

MarkAStevens04 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Hi @nivedita9009!! Thank you SO MUCH for making your first contribution πŸŽ‰, we're lucky to have you!! Please make sure you've filled out the pull request template, it'll make reviewing this change a lot easier! Feel free to just attach as a comment to this PR. ❀️

Closes {LINK TO GH ISSUE}

## πŸ‘‹ Before you open this PR

Hi there, thanks SO MUCH for contributing!! πŸ’› This template helps us review your work quickly and give good feedback. It looks longer than it is, most PRs only need a few sections.

You own every line in this PR as if you typed it by hand. LLMs are allowed here, they're helpful tools, but the human opening the PR is the one we'll be talking to in review, so we just want to make sure that the person understands the code. The more an LLM did, the more we ask you to show that understanding. That's it. No gotchas.

How to contribute: https://github.com/MarkAStevens04/cloudflare-kinetics-editor/blob/main/CONTRIBUTING.md


## πŸ€” Section A - Description
*(Everyone fills this out.)*

A clear and concise description of what this PR does.

Use this section for review hints, explanations or discussion points/todos.

- What changed
- Why
- Anything reviewers should know (review hints, open questions, TODOs, discussion points, etc.)

## βœ… Verification

*(Everyone fills this out. It's the fastest way for us to trust your change!)*

Show us it works! Paste a screenshot, test results, etc. Even just a list of steps you did to make sure your code is working! 

[ ] I ran this code locally and it does what the description says

## πŸ”Ž Quick Self Check
*(Everyone does this, a quick 30 second pass before you submit)*

- [ ] This PR is **one logical change**. (Big or architectural? Let's chat in an issue first before writing code πŸ™)
- [ ] No leftover dead code, debugging prints, or unused imports
- [ ] Every import / API / dependency I reference actually exists and is already available
- [ ] Comments explain *why* not what, and the style matches the surrounding file.
- [ ] I used existing functions and components where possible.
- [ ] My style matches the surrounding code to the best of my ability
- [ ] I could re-derive any non-obvious line if you asked me to

## πŸ€– Used an LLM? 
*(Skip this if you wrote everything yourself!)*

Telling us where you used an LLM isn't a strike against you. It's helpful context, and we appreciate the honesty! πŸ’¬

- **Where an LLM helped:** (which files / sections, roughly)
- **The gist**: in your own words, what does that code do and why did you take this approach over the obvious alternative? 

You don't need to justify every line, just the parts that are complex, risky, or that someone might reasonably question. If a chunk of generated code is doing something non-obvious, walk us through your thinking there. 

## πŸ” When we request changes

We review to make the code better, not to nitpick. We'd also love to help you grow as a contributor! 🌱 When we leave comments:

- **Please reply inline and update *this* PR.** Push new commits to the same branch.
- **Please don't close this and open a brand-new PR** with regenerated code. We lose the whole conversation that way, and it usually reintroduces the things we just fixed. Iterating in place is faster for both of us.

Thanks again for contributing, we're glad you're here!! πŸŽ‰


## πŸ“œ BioBuilder Contributor License Agreement

I give Mark Stevens and BioBuilder permission to license my contributions on any terms they like. I am giving them this license in order to make it possible for them to accept my contributions into their project.

**_As far as the law allows, my contributions come as is, without any warranty or condition, and I will not be liable to anyone for any damages related to this software or this license, under any kind of legal claim._**

@MarkAStevens04 MarkAStevens04 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just please fill out that PR template in the comment above and I'll be able to give a more accurate review!

Comment thread src/react-app/App.tsx Outdated
<TutorialPopup />

<RxnDrawer />
{tutorialPhase !== 0 && <SimulationDrawer />}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this formatting cleanup!

Comment thread src/react-app/App.tsx
@MarkAStevens04 MarkAStevens04 added the awaiting author πŸ™Œ Waiting for the author to respond label Jun 30, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

πŸ‘‹ Thank you SO MUCH for contributing!! We ask that you fill out the following template so that we can review your code easier and get it live as quickly as possible! πŸ’›

Here's what still needs attention:

  • The ## πŸ“œ BioBuilder Contributor License Agreement section has been altered. It must be left exactly as it appears in the template.
πŸ“‹ Click to expand the full template
Closes {LINK TO GH ISSUE}

## πŸ‘‹ Before you open this PR

Hi there, thanks SO MUCH for contributing!! πŸ’› This template helps us review your work quickly and give good feedback. It looks longer than it is, most PRs only need a few sections.

You own every line in this PR as if you typed it by hand. LLMs are allowed here, they're helpful tools, but the human opening the PR is the one we'll be talking to in review, so we just want to make sure that the person understands the code. The more an LLM did, the more we ask you to show that understanding. That's it. No gotchas.

How to contribute: https://github.com/MarkAStevens04/cloudflare-kinetics-editor/blob/main/CONTRIBUTING.md


## πŸ€” Section A - Description
*(Everyone fills this out.)*

A clear and concise description of what this PR does.

Use this section for review hints, explanations or discussion points/todos.

- What changed
- Why
- Anything reviewers should know (review hints, open questions, TODOs, discussion points, etc.)

## βœ… Verification

*(Everyone fills this out. It's the fastest way for us to trust your change!)*

Show us it works! Paste a screenshot, test results, etc. Even just a list of steps you did to make sure your code is working! 

[ ] I ran this code locally and it does what the description says

## πŸ”Ž Quick Self Check
*(Everyone does this, a quick 30 second pass before you submit)*

- [ ] This PR is **one logical change**. (Big or architectural? Let's chat in an issue first before writing code πŸ™)
- [ ] No leftover dead code, debugging prints, or unused imports
- [ ] Every import / API / dependency I reference actually exists and is already available
- [ ] Comments explain *why* not what, and the style matches the surrounding file.
- [ ] I used existing functions and components where possible.
- [ ] My style matches the surrounding code to the best of my ability
- [ ] I could re-derive any non-obvious line if you asked me to

## πŸ€– Used an LLM? 
*(Skip this if you wrote everything yourself!)*

Telling us where you used an LLM isn't a strike against you. It's helpful context, and we appreciate the honesty! πŸ’¬

- **Where an LLM helped:** (which files / sections, roughly)
- **The gist**: in your own words, what does that code do and why did you take this approach over the obvious alternative? 

You don't need to justify every line, just the parts that are complex, risky, or that someone might reasonably question. If a chunk of generated code is doing something non-obvious, walk us through your thinking there. 

## πŸ” When we request changes

We review to make the code better, not to nitpick. We'd also love to help you grow as a contributor! 🌱 When we leave comments:

- **Please reply inline and update *this* PR.** Push new commits to the same branch.
- **Please don't close this and open a brand-new PR** with regenerated code. We lose the whole conversation that way, and it usually reintroduces the things we just fixed. Iterating in place is faster for both of us.

Thanks again for contributing, we're glad you're here!! πŸŽ‰


## πŸ“œ BioBuilder Contributor License Agreement

I give Mark Stevens and BioBuilder permission to license my contributions on any terms they like. I am giving them this license in order to make it possible for them to accept my contributions into their project.

**_As far as the law allows, my contributions come as is, without any warranty or condition, and I will not be liable to anyone for any damages related to this software or this license, under any kind of legal claim._**

This check re-runs automatically when you edit the description, so it'll clear once everything's in place.

@nivedita9009 nivedita9009 deleted the fix-delete-key branch July 1, 2026 12:52
@nivedita9009 nivedita9009 restored the fix-delete-key branch July 1, 2026 12:52
@MarkAStevens04

MarkAStevens04 commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Hey @nivedita9009! I'm really proud of the progress you've made and I'm sad to see this was closed. Feel free to open a new PR or reopen this one if you'd still like your changes merged! ❀️

I'm going to unassign the issue since you closed the PR, but let me know if you'd like me to re-assign it to you and I'd be more than happy 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting author πŸ™Œ Waiting for the author to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Del" button allows delete

2 participants