Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use collection expressions instead of ImmutableArray.Create #4546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use collection expressions instead of ImmutableArray.Create #4546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...la.Analyzers/Csla.Analyzers/AsynchronousBusinessRuleInheritingFromBusinessRuleAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public sealed class AsynchronousBusinessRuleInheritingFromBusinessRuleAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(inheritsFromBusinessRuleRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [inheritsFromBusinessRuleRule];

/// <summary>
///
Expand Down
4 changes: 2 additions & 2 deletions ...ers/AsynchronousBusinessRuleInheritingFromBusinessRuleChangeToBusinessRuleAsyncCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ public sealed class AsynchronousBusinessRuleInheritingFromBusinessRuleChangeToBu
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds =>
ImmutableArray.Create(AnalyzerIdentifiers.AsynchronousBusinessRuleInheritance);
public override ImmutableArray<string> FixableDiagnosticIds => [AnalyzerIdentifiers.AsynchronousBusinessRuleInheritance];

/// <summary>
///
/// </summary>
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/BusinessRuleDoesNotUseAddMethodsOnContextAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public sealed class BusinessRuleDoesNotUseAddMethodsOnContextAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(usesAddMethodsOnContextRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [usesAddMethodsOnContextRule];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/CheckConstructorsAnalyzerPublicConstructorCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ public sealed class CheckConstructorsAnalyzerPublicConstructorCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds =>
ImmutableArray.Create(Constants.AnalyzerIdentifiers.PublicNoArgumentConstructorIsMissing);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.PublicNoArgumentConstructorIsMissing];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/DoesChildOperationHaveRunLocalAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public sealed class DoesChildOperationHaveRunLocalAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(childHasRunLocalRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [childHasRunLocalRule];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/DoesChildOperationHaveRunLocalRemoveAttributeCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public sealed class DoesChildOperationHaveRunLocalRemoveAttributeCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.DoesChildOperationHaveRunLocal);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.DoesChildOperationHaveRunLocal];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/DoesOperationHaveAttributeAddAttributeCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public sealed class DoesOperationHaveAttributeAddAttributeCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.DoesOperationHaveAttribute);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.DoesOperationHaveAttribute];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/DoesOperationHaveAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public sealed class DoesOperationHaveAttributeAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(operationAttributeRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [operationAttributeRule];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/EvaluateManagedBackingFieldsAnalayzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public sealed class EvaluateManagedBackingFieldsAnalayzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(mustBePublicStaticAndReadonlyRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [mustBePublicStaticAndReadonlyRule];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/EvaluateManagedBackingFieldsCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public sealed class EvaluateManagedBackingFieldsCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.EvaluateManagedBackingFields);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.EvaluateManagedBackingFields];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/EvaluateOperationAttributeUsageAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public sealed class EvaluateOperationAttributeUsageAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(operationUsageRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [operationUsageRule];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/EvaluatePropertiesForSimplicityAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public sealed class EvaluatePropertiesForSimplicityAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(onlyUseCslaPropertyMethodsInGetSetRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [onlyUseCslaPropertyMethodsInGetSetRule];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/FindBusinessObjectCreationAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public sealed class FindBusinessObjectCreationAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(objectCreatedRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [objectCreatedRule];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion ...nalyzers/Csla.Analyzers/FindOperationsWithIncorrectReturnTypeResolveCorrectTypeCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public sealed class FindOperationsWithIncorrectReturnTypeResolveCorrectTypeCodeF
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.FindOperationsWithIncorrectReturnTypes);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.FindOperationsWithIncorrectReturnTypes];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/FindOperationsWithIncorrectReturnTypesAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ public sealed class FindOperationsWithIncorrectReturnTypesAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(shouldOnlyReturnVoidOrTaskRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [shouldOnlyReturnVoidOrTaskRule];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/FindOperationsWithNonSerializableArgumentsAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ public sealed class FindOperationsWithNonSerializableArgumentsAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(shouldUseSerializableTypesRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [shouldUseSerializableTypesRule];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/FindRefAndOutParametersInOperationsAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public sealed class FindRefAndOutParametersInOperationsAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(incorrectParameterRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [incorrectParameterRule];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/FindSaveAssignmentIssueAnalyzerAddAssignmentCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public sealed class FindSaveAssignmentIssueAnalyzerAddAssignmentCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.FindSaveAssignmentIssue);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.FindSaveAssignmentIssue];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion ...Csla.Analyzers/Csla.Analyzers/FindSaveAssignmentIssueAnalyzerAddAsyncAssignmentCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public sealed class FindSaveAssignmentIssueAnalyzerAddAsyncAssignmentCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.FindSaveAsyncAssignmentIssue);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.FindSaveAsyncAssignmentIssue];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions Source/Csla.Analyzers/Csla.Analyzers/IsCompleteCalledInAsynchronousBusinessRuleAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public sealed class IsCompleteCalledInAsynchronousBusinessRuleAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(completeCalledInAsyncBusinessRuleRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [completeCalledInAsyncBusinessRuleRule];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions ...a.Analyzers/Csla.Analyzers/IsCompleteCalledInAsynchronousBusinessRuleRemoveCallCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ public sealed class IsCompleteCalledInAsynchronousBusinessRuleRemoveCallCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds =>
ImmutableArray.Create(Constants.AnalyzerIdentifiers.CompleteInExecuteAsync);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.CompleteInExecuteAsync];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/IsOperationMethodPublicMakeNonPublicCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public sealed class IsOperationMethodPublicMakeNonPublicCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.IsOperationMethodPublic);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.IsOperationMethodPublic];

/// <summary>
///
Expand Down
3 changes: 1 addition & 2 deletions ...sla.Analyzers/ManagedBackingFieldUsesNameof/EvaluateManagedBackingFieldsNameofAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ public sealed class EvaluateManagedBackingFieldsNameofAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(shouldUseNameofRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [shouldUseNameofRule];

/// <summary>
///
Expand Down
2 changes: 1 addition & 1 deletion ...Csla.Analyzers/ManagedBackingFieldUsesNameof/EvaluateManagedBackingFieldsNameofCodeFix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public sealed class EvaluateManagedBackingFieldsNameofCodeFix
/// <summary>
///
/// </summary>
public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(Constants.AnalyzerIdentifiers.EvaluateManagedBackingFieldsNameof);
public override ImmutableArray<string> FixableDiagnosticIds => [Constants.AnalyzerIdentifiers.EvaluateManagedBackingFieldsNameof];


/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Source/Csla.Analyzers/Csla.Analyzers/ObjectAuthorizationRulesAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public sealed class ObjectAuthorizationRulesAttributeAnalyzer
/// <summary>
///
/// </summary>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(missingAttributeRule, shouldBePublicRule, shouldBeStaticRule);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [missingAttributeRule, shouldBePublicRule, shouldBeStaticRule];

/// <summary>
///
Expand Down
Loading