Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-36337 udf - runtime error: call to function (udf_example) netaphon through pointer to incorrect function type #3906

Open
wants to merge 4 commits into
base: 10.6
Choose a base branch
from

Conversation

grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-36337

Description

This a change to the example udf function and the udf functions of connect to match the calling convention of unsigned char * for is_null and error in the interfaces matching include/sql_udf.h.

Also included a quick patch to disable the archive-big test under MSAN that was causing troubles (its never been tested in CI before).

Release Notes

Non-user facing change. or update connect udf function to match calling conventions of udf plugins.

How can this PR be tested?

MTR test under clang WITH_UBSAN

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate. (though slightly lax on line length)
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

archive.archive-big                      w1 [ fail ]  timeout after 900 seconds
        Test ended at 2025-03-19 22:27:30

Test case timeout after 900 seconds

== /build/mysql-test/var/1/log/archive-big.log ==
CREATE TABLE t1(a BLOB) ENGINE=ARCHIVE;
INSERT INTO t1 SELECT * FROM t1;
...

 == /build/mysql-test/var/1/tmp/analyze-timeout-mysqld.1.err ==
mysqltest: Could not open connection 'default' after 500 attempts: 2002 Can't connect to local MySQL server through socket '/build/mysql-test/var/tmp/1/mysqld.1.sock' (111)
This is required to match the sql/sql_udf.h
@grooverdan grooverdan added the MariaDB Foundation Pull requests created by MariaDB Foundation label Mar 21, 2025
@grooverdan grooverdan requested a review from bnestere March 21, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MariaDB Foundation Pull requests created by MariaDB Foundation
Development

Successfully merging this pull request may close these issues.

1 participant