This repository has been archived by the owner on May 27, 2024. It is now read-only.
cmake: support find_package(psimd) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
ConnorBaker
force-pushed
the
feat/support-cmake-find-package
branch
2 times, most recently
from
f11afca to
601943a
Compare
ConnorBaker
force-pushed
the
feat/support-cmake-find-package
branch
from
601943a to
2d7f3bd
Compare
|
@Maratyszcza if you have the time, would you mind reviewing this? |
chuckatkins
reviewed
Jan 4, 2024
| @@ -1,17 +1,27 @@ | |||
| CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12 FATAL_ERROR) | |||
| CMAKE_MINIMUM_REQUIRED(VERSION 3.0 FATAL_ERROR) | |||
|
|
|||
| INCLUDE(GNUInstallDirs) | |||
There was a problem hiding this comment.
While you're in here it'd be good to move this include to after PROJECT since the GNUInstallDirs module uses platform information initialized by PROJECT to determine the default lib directory:
CMake Warning (dev) at /opt/cmake/3.27.7/share/cmake-3.27/Modules/GNUInstallDirs.cmake:243 (message):
Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
target architecture is known. Please enable at least one language before
including GNUInstallDirs.
Call Stack (most recent call first):
CMakeLists.txt:3 (INCLUDE)
This warning is for project developers. Use -Wno-dev to suppress it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CMake configuration file to make it possible for CMake-based projects to use
find_packageto consume this library.