Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chopsticks for runtime upgrade testing #1356

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Nov 11, 2024

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-automation Area: Issues and PRs related to Automation L-added Log: Issues and PRs related to addition A-benchmark-checks A-integration-test-checks A-unit-test-checks labels Nov 11, 2024
Signed-off-by: Jamie <[email protected]>
anaye1997
anaye1997 previously approved these changes Nov 12, 2024
@ace155 ace155 dismissed anaye1997’s stale review November 12, 2024 10:34

not valid approver

@Dengjianping Dengjianping merged commit fddc081 into manta Nov 12, 2024
18 of 19 checks passed
@Dengjianping Dengjianping deleted the chop-rt-upgrade branch November 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-benchmark-checks A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants