🔧 First draft of helm #3
Conversation
Signed-off-by: afreyermuth98 <[email protected]>
Signed-off-by: afreyermuth98 <[email protected]>
There was a problem hiding this comment.
That's a solid start. Thanks for volunteering :) I like that you made naming/namespacing configurable.
The cert-manager part seems to be missing, and our original cert-manager manifest appears to have been dropped. The hook cannot function without TLS enabled as far as I know. I'm not familiar with how folks deal with their PKI without cert-manager these days - so I don't know if it makes sense to support something else.
A nitpick: I'm not sure adding suffixes to resources names like -cluster-role or -role is idiomatic - even though it does happen in the wild - most resources are not named like that. After all, the resources do have a well defined type that transpires through kubectl get role/rolename for instance.
| admissionReviewVersions: [ "v1" ] | ||
| sideEffects: None | ||
| failurePolicy: Ignore | ||
| timeoutSeconds: 2 |
There was a problem hiding this comment.
I recommend a 1 second timeout here, and it could be worth making this customizable through values.
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| name: "{{ include "knss.fullname" . }}-test-connection" |
There was a problem hiding this comment.
The knss abbreviation seems to only be in use here and not part of _helpers as they are.
There was a problem hiding this comment.
lol yeah I first created the name chart with the name knss and then renamed it because i didn't like it. I'll correct that ^^
There was a problem hiding this comment.
I think that deletion may have been an accident.
PR about this issue :
#2 (comment)