Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relax loose version of rdkit #302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

relax loose version of rdkit #302

wants to merge 1 commit into from

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Mar 6, 2025

due to #297 this should be fine now (cf. also #293)

jalew188
jalew188 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make more sense to keep rdkit up-to-date

boopthesnoot
boopthesnoot approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@boopthesnoot boopthesnoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the tests pass

@sophiamaedler sophiamaedler mentioned this pull request Mar 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalew188 jalew188 jalew188 approved these changes

@sophiamaedler sophiamaedler sophiamaedler approved these changes

@boopthesnoot boopthesnoot boopthesnoot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mschwoer @jalew188 @sophiamaedler @boopthesnoot