Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieval of total position/progress ratio in transcoder #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

das-kaesebrot
Copy link

Hi!
Thank you for this library, it provides almost all of the features I'm looking for!

As I've noticed, it would be helpful to be able to retrieve the total position across all source streams to be able to calculate a transcoding progress ratio. Or, even better, a way to retrieve the current progress from the transcoder either via passing a callback method or a getter.

I've tried my luck at implementing a simple getter method for the position. During testing I divided it by the sum of all packet durations to get a total progress ratio, which seemed to work out fine.

Unfortunately, I am not as familiar with the whole library (or JavaCV) yet - would it somehow be possible to retrieve the total duration of all streams before handling the packets inside the transcoder class?

@das-kaesebrot das-kaesebrot marked this pull request as ready for review August 29, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant