Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for keep alive timeouts #513

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added support for keep alive timeouts #513

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45f52e0
added support for keep alive timeouts
khchau7 Aug 12, 2021
b2c39fd
keep alive timeout bug fixes
khchau7 Aug 16, 2021
02c41b9
adding timeout seconds to options in watch entities
khchau7 Aug 20, 2021
b85ec71
adding timeout seconds to options in watch entities
khchau7 Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/kubeclient.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ def define_entity_methods
# This method used to take resource_version as a param, so
# this conversion is to keep backwards compatibility
options = { resource_version: options } unless options.is_a?(Hash)
options[timeoutSeconds] = 380 # 6 mins 20 seconds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean :timeoutSeconds ?
This will override any passed-in timeout. I'm assuming you're just experimenting for now, but this can't be merged.


watch_entities(entity.resource_name, options, &block)
end
Expand Down