bugfix 2d tile depth #128
Open
bugfix 2d tile depth #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
commented
Dec 31, 2024
| @@ -205,7 +205,7 @@ function setup_axis!(axis::Axis, ext_target, crs) | |||
| X = ext_target.X | |||
| Y = ext_target.Y | |||
| axis.autolimitaspect = 1 | |||
| Makie.limits!(axis, (X[1], X[2]), (Y[1], Y[2])) | |||
There was a problem hiding this comment.
Ooops this is just to fix the other bug that hangs vscode, but should be removed
asinghvi17
reviewed
Jan 1, 2025
| @@ -126,7 +147,7 @@ function cull_plots!(m::Map) | |||
| end | |||
| end | |||
|
|
|||
| function create_tile_plot!(m::AbstractMap, tile::Tile, data) | |||
| function create_tyler_plot!(m::AbstractMap, tile::Tile, data) | |||
There was a problem hiding this comment.
Reminder to self: we need to document this name change and apply it to the GeoMakie extension + all other Tyler plot configs
There was a problem hiding this comment.
Oh is this interface? Need to make that clear.
It can be some other name but there is already create_tileplot without underscore in the interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ice melt demo so that the simulation is seen, and various z level plots behave well like they did previously.
It splits up depth scaling into plots above and below z level, and uses
visible=false/visible=trueas well as depth so that the top layer is always at zero, and the background is either below it how hidden if it has a higher zoom.It also moves the whole plot down by 10 so none of this jiggling around affects other plots.
And reorganises code a little.