New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GWAR-1011 Linting and try/catch block to fix IE11 issue DO NOT MERGE #2

Open

dsmith11211 wants to merge 1 commit into allow-multiple-containers from allow-multiple-containers-with-ie11-fix

dsmith11211 commented May 18, 2017

@stevekoller This fix was to stop scrollMonitor from throwing an exception in IE11 when trying to access a node that wasn't in the DOM.

if (isWindowScrollMonitor(this.scrollMonitor.$container)) {
    thisRect = this;
 } else {
        //GWAR-1011 Wrap in try/catch to prevent IE11 from choking
       try {
            thisRect = this.watchItem.getBoundingClientRect();
        } catch (e) {
            //do nothing
        }
}

Everything else is just linting. I'm not sure if we need to merge this in. I am just going to use this branch ref for now.


          GWAR-1011 Linting and try/catch block to fix IE11 issue

f03cdbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet