Skip to content

Conversation

@shanecowherd
Copy link
Contributor

Tested on multiple Macs running High Sierra.

Copy link
Member

@dinhvh dinhvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with improving documentation.
Could you make the suggested changes so that we can merge those improved instructions in the codebase?

Thanks!


Copy the headers into the build folder
```
mkdir -p ../build-android/include/MailCore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we could make sure build.sh does it for us?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the build.sh script to take care of it instead of adding more instructions?

Open terminal and set two temporary export variables
* (Make sure they point to your SDK and NDK folders)
```
export ANDROID_SDK=/Users/YOURNAME/Library/Android/sdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep it as /path/to/android-sdk (and maybe provide a specific example).

Like

$ export ANDROID_SDK=/path/to/android-sdk # /Users/username/Library/Android/sdk

* (Make sure they point to your SDK and NDK folders)
```
export ANDROID_SDK=/Users/YOURNAME/Library/Android/sdk
export ANDROID_NDK=/Users/YOURNAME/Downloads/android-ndk-r13b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads is not a great path to install a SDK/NDK ;)

Tested with macOS 10.13.6, Android Studio 3.1.4

Install Java 6, 8, or 10
* http://www.oracle.com/technetwork/java/javase/downloads/jdk10-downloads-4416644.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try not being too specific with downloads URLs?
Java version will evolve over time and I'd like to avoid changing these instructions too often.

* http://www.oracle.com/technetwork/java/javase/downloads/jdk10-downloads-4416644.html
* Building with Java 8 or 10 might throw a few warnings during the build, but it will still build

Download the Required Android SDKs (16, 21, 22)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with Android SDK and NDK.

@vonox7
Copy link
Contributor

vonox7 commented Apr 20, 2021

Fyi: #1912 explains the build pipeline on Android that works also in 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants