refactor: replace DialectManager class with resolveModelDialect function#79
Open
MayCXC wants to merge 2 commits intoMadAppGang:mainfrom
Open
refactor: replace DialectManager class with resolveModelDialect function#79MayCXC wants to merge 2 commits intoMadAppGang:mainfrom
MayCXC wants to merge 2 commits intoMadAppGang:mainfrom
Conversation
MayCXC
force-pushed
the
refactor/unified-provider-registry
branch
3 times, most recently
from
e12ccfd to
3cc0e69
Compare
MayCXC
changed the title
4 tasks
MayCXC
changed the title
MayCXC
force-pushed
the
refactor/unified-provider-registry
branch
4 times, most recently
from
dbe349b to
110d503
Compare
DialectManager had no state: constructor allocated all dialects, getAdapter() did a linear scan, needsTransformation() called getAdapter() again. Replace with a pure function that does the same scan without the class ceremony. All callers updated: composed-handler, cli, local-adapter, openrouter-api-format, and all test files.
MayCXC
force-pushed
the
refactor/unified-provider-registry
branch
from
110d503 to
78b1f5d
Compare
MayCXC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the stateless
DialectManagerclass with a pureresolveModelDialect()function. The class had no state: constructor allocated all dialects eagerly,getAdapter()did a linear scan,needsTransformation()calledgetAdapter()again. The function does the same work without the class ceremony.Rebased onto v6.2.2.
DialectManagerclass replaced byresolveModelDialect(modelId): BaseAPIFormatTest plan
bun testpasses (149/149 across 3 test files)