Use IJunctionRestrictionsHook instead of patching#55
Draft
Elesbaan70 wants to merge 2 commits intoMacSergey:masterfrom
Draft
Use IJunctionRestrictionsHook instead of patching#55Elesbaan70 wants to merge 2 commits intoMacSergey:masterfrom
Elesbaan70 wants to merge 2 commits intoMacSergey:masterfrom
Conversation
…ing. Possible use of Cyrillic characters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates NCR's patches to the
JunctionRestrictionsMangagerclass, so that we can remove redundant deprecated methods without breaking NCR. It is currently a draft PR and cannot be merged until TMPE's plannedIJunctionRestrictionsHookAPI is released to stable. Right now it can be tested by building TMPE from the following branch: https://github.com/Elesbaan70/TMPE/tree/junction-restrictions-hookNote that this PR includes #54 because the project would not build on English-language systems without that change.