Handle HTTP status errors in streaming sessions #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SplittyDev
force-pushed
the
upstream/streaming-error-handling
branch
2 times, most recently
from
35b0793 to
e7bf67f
Compare
SplittyDev
force-pushed
the
upstream/streaming-error-handling
branch
from
e7bf67f to
3447365
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds proper HTTP error handling to
StreamingSession, and exposes access to both theHTTPURLResponseas well as thestatusCodeviaOpenAIError/statusError.Why
HTTP status errors (404, 500, etc.) aren't currently handled in streaming sessions. Instead, if an error is encountered, the streaming session simply terminates without yielding any chunks, which is very much unexpected.
Affected Areas
This is simply an additional delegate method implementation on
StreamingSession(urlSession(session:dataTask:didReceive:completionHandler:)), and it's mostly an internal change that's transparent to users.Users should already be handling
OpenAIErroranyway, so hopefully this shouldn't cause any unexpected behavior for anyone. Personally, I would not consider this a breaking change.