refactor: A complete flutter+Dependency+Code Upgrade - #22
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41164729bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Future<void> _submitKey() async { | ||
| final key = _keyController.text.trim(); | ||
| if (key.length < 10 || !key.startsWith("AIza")) { | ||
| if (key.isEmpty) { |
There was a problem hiding this comment.
With this relaxed check, any non-empty clipboard value is saved as the Gemini key; SplashScreen._checkUserStatus then treats any non-empty stored value as setup complete, and the repo has no UI path that calls deleteKey(). If a user accidentally pastes a URL, email, or other non-AIza value, they now skip onboarding on every launch and cannot correct the key without clearing app data, so please retain a basic key-shape validation or add an in-app reset path before accepting arbitrary text.
Useful? React with 👍 / 👎.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
No description provided.