Improve appstream metadata based on appstream generator feedback #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace http with https urls and change ID to reverse DNS notation. Added reference to .desktop file and icon. Added rating information based on the fact that this can be used to stream video to the Internet. This patch is in Debian as 2000-appstream-metadata-https.patch.
petterreinholdtsen
added a commit
to petterreinholdtsen/ssr
that referenced
this pull request
May 8, 2024
Adjusted based on feedback from the Appstream validator (appstreamcli validate-tree). Changed metainfo ID and file names to use reverse DNS notation. Added categories, homepage URL and icon reference to the metainfo file. Changed URLs to SSL secured variants. This replaces the changes proposed in pull requests MaartenBaert#993 and MaartenBaert#994.
|
Replaced by #1032. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace http with https urls and change ID to reverse DNS notation. Added reference to .desktop file and icon. Added rating information based on the fact that this can be used to stream video to the Internet.
This patch is in Debian as 2000-appstream-metadata-https.patch.