Fix lecture creation #752
Open
Fix lecture creation #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterfarrell9
requested a deployment
to
testing-review
GitHub Actions
Waiting
fosterfarrell9
requested a deployment
to
testing-review
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #739. Turns out it was just a conditional that was forgotten in the restructuring of access rights in #671: Since there does no longer appear a form where you can select the teacher (unless you are admin), the javascript produced by
lectures/new.coffeecrashes. This has no consequence on/administration(where the exception also occurs), but oncourses/:id/editthis prevents the modal from popping up.I guess, some cypress tests should still be written for that.
UPDATE: After I had introduced the missing conditional in this commit I decided it might be better just to let the backend do the job, so i just removed the corresponding js.