Feat(task): Check schema update#26
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
…IPP reporting Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ImmyBot task that deploys/manages the CyberDrain “Check” browser extension policies so its registry writes match the current upstream managed schema (notably: new policy areas and Chromium-style array storage).
Changes:
- Adds new task parameters and corresponding policy writes (toolbar pinning, valid badge timeout, domain squatting, generic webhook, new branding URLs, CIPP tenant override).
- Changes
urlAllowliststorage from a single value to numbered string entries under aurlAllowlistsubkey, matching upstream schema/behavior. - Refactors CIPP tenant ID resolution to an explicit script-scope
$effectiveCippTenantIdand passes it intoGet-DesiredItem.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
MWG-Logan
added a commit
that referenced
this pull request
Apr 28, 2026
* feat(Deploy-CheckExtension): add domain squatting detection parameters Co-authored-by: Copilot <copilot@github.com> * feat(Deploy-CheckExtension): add CippTenantIdOverride parameter for CIPP reporting Co-authored-by: Copilot <copilot@github.com> * feat(Deploy-CheckExtension): clean stale registry entries for extensions Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Deploy-CheckExtension.ps1 to match upstream managed schema
Brings the CyberDrain Check extension deployment task in line with the current managed_schema.json and upstream deploy script.
New Parameters
ForceToolbarPintoolbar_state, Chrome:toolbar_pin)ValidPageBadgeTimeoutDomainSquattingEnabledDomainSquattingDeviationThresholdDomainSquattingLevenshteinDomainSquattingHomoglyphDomainSquattingTyposquatDomainSquattingCombosquatDomainSquattingProtectedDomainsDomainSquattingActionDomainSquattingLogDetectionsEnableGenericWebhookWebhookUrlWebhookEventsSupportUrlPrivacyPolicyUrlAboutUrlCippTenantIdOverride$azureTenantIdfor CIPP reportingChanged
urlAllowlist: Changed from a singleMultiStringregistry value on the policy key to numbered String entries in aurlAllowlistsubkey (1,2,3…), matching the upstream deploy script and how Chromium actually reads managed storage arrays.CippTenantIdresolution: Resolved at script scope into$effectiveCippTenantId(override →$azureTenantIdfallback) and passed explicitly intoGet-DesiredItem. Fixes the scope-leak bug present in the Global repo version.Removed
$CompanyUrlparameter —companyURLbranding key is not in the upstream managed schema.Registry Structure (for reference)