Skip to content

v0.0.3 - Secure Access #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MWG-Logan merged 4 commits into from
Jan 14, 2026
Merged

v0.0.3 - Secure Access #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7988482
Bump Microsoft.FluentUI.AspNetCore.Components from 4.13.1 to 4.13.2 (…
dependabot[bot] Jan 7, 2026
d494e47
Bump QuestPDF from 2025.4.0 to 2025.12.1 (#39)
dependabot[bot] Jan 7, 2026
303183c
Bump Microsoft.FluentUI.AspNetCore.Components.Icons from 4.13.1 to 4.…
dependabot[bot] Jan 8, 2026
f3e3cc2
fix(web): Change allowedRoles from 'authenticated' to 'editor' (#42)
MWG-Logan Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bezalu.ProjectReporting.API/Bezalu.ProjectReporting.API.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" Version="2.0.7" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
<PackageReference Include="Azure.AI.OpenAI" Version="2.1.0" />
<PackageReference Include="QuestPDF" Version="2025.4.0" />
<PackageReference Include="QuestPDF" Version="2025.12.1" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions Bezalu.ProjectReporting.Web/Bezalu.ProjectReporting.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
<PackageReference Include="Markdig" Version="0.44.0" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="10.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="Microsoft.FluentUI.AspNetCore.Components" Version="4.13.1" />
<PackageReference Include="Microsoft.FluentUI.AspNetCore.Components.Icons" Version="4.13.1" />
<PackageReference Include="Microsoft.FluentUI.AspNetCore.Components" Version="4.13.2" />
<PackageReference Include="Microsoft.FluentUI.AspNetCore.Components.Icons" Version="4.13.2" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 5 additions & 1 deletion Bezalu.ProjectReporting.Web/staticwebapp.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
"route": "/login",
"rewrite": "/.auth/login/aad"
},
{
"route": "/manifest.webmanifest",
"allowedRoles": [ "anonymous" ]
},
{
"route": "/*",
"allowedRoles": ["authenticated"]
"allowedRoles": [ "editor" ]
Comment thread
MWG-Logan marked this conversation as resolved.
Comment thread
MWG-Logan marked this conversation as resolved.
}
Comment on lines 11 to 14
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catch-all route "/" with "editor" role requirement will apply to all routes including API routes (/api/). This means API endpoints will also require the "editor" role, not just the web UI. If the intent is to have different authorization requirements for API routes versus the web UI, you should add explicit route configurations for /api/* routes before the catch-all route. For example:

{
  "route": "/api/*",
  "allowedRoles": ["authenticated"]
}

Otherwise, ensure that the "editor" role requirement for API access is intentional and documented.

Copilot uses AI. Check for mistakes.
Comment on lines 11 to 14
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the catch-all route now requiring "editor" role, static assets like CSS (/css/), JavaScript (/js/), icons (/icon-*.png), and favicon (/favicon.ico) will also require authentication with the "editor" role. While these are excluded from navigationFallback, they are not excluded from route authorization.

For a typical web application, these static assets should be accessible without authentication to allow the application shell to load before authentication. Consider adding explicit route entries for these static assets with anonymous access:

{
  "route": "/css/*",
  "allowedRoles": ["anonymous"]
},
{
  "route": "/js/*",
  "allowedRoles": ["anonymous"]
},
{
  "route": "/favicon.ico",
  "allowedRoles": ["anonymous"]
},
{
  "route": "/icon-*.png",
  "allowedRoles": ["anonymous"]
}

These routes should be added before the catch-all "/*" route.

Copilot uses AI. Check for mistakes.
Comment thread
MWG-Logan marked this conversation as resolved.
],
"navigationFallback": {
Expand Down
Loading