Conversation
… configuration (#34) * Initial plan * Add navigationFallback to fix auth routing issue Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com> * Add critical /.auth/* exclusion to navigationFallback Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com> * Update documentation to explain authentication configuration Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com> * Update Bezalu.ProjectReporting.Web/staticwebapp.config.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add service-worker.published.js to static web app config --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Add project picker feature with active project listing Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com> * Address code review feedback: improve error handling and null checks Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com> * Improve error messages to avoid exposing sensitive information Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MWG-Logan <2997336+MWG-Logan@users.noreply.github.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://mango-river-0addcf70f-35.eastus2.2.azurestaticapps.net |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a project selection workflow that allows users to choose from a list of active ConnectWise projects before generating a completion report, significantly improving the user experience. The changes include a new backend API endpoint to retrieve active projects, frontend UI enhancements with a data grid for project selection, and improved authentication configuration and documentation.
Key Changes:
- Added
/api/projectsendpoint to retrieve active projects from ConnectWise - Refactored the home page to display projects in a selectable data grid before report generation
- Enhanced Static Web App configuration with proper navigation fallback and exclusions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Bezalu.ProjectReporting.API/Functions/ProjectsFunction.cs |
New Azure Function providing the GET /api/projects endpoint |
Bezalu.ProjectReporting.API/Services/ProjectReportingService.cs |
Added GetActiveProjectsAsync method to query ConnectWise for active projects |
Bezalu.ProjectReporting.Shared/DTOs/ProjectCompletionReportModels.cs |
New ProjectListItem DTO for project list data |
Bezalu.ProjectReporting.Web/Pages/Home.razor |
Major UI refactor with project selection grid, improved error handling, and better user flow |
Bezalu.ProjectReporting.Web/staticwebapp.config.json |
Added navigationFallback configuration with exclusions for authentication and static assets |
README.md |
Enhanced authentication flow documentation with SPA routing details |
docs/deployment.md |
Updated deployment documentation with authentication and routing configuration details |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Renamed and relocated Azure Function for project completion reports (ProjectCompletionReportFunction → ReportFunction) for better organization. - Broadened "active" project filter to include "In Progress" status in ProjectReportingService. - Enhanced Blazor UI to detect 401 Unauthorized responses and show a login prompt with sign-in button. - Updated staticwebapp.config.json to require authentication for all routes (/*) instead of just /api/*. - Minor UI formatting improvements to data grids.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://mango-river-0addcf70f-35.eastus2.2.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that allows users to select from a list of active projects before generating a project completion report, improving the user experience and workflow. It adds a new API endpoint to retrieve active projects, updates the frontend to display a project selection table, and enhances authentication configuration and documentation.
Backend/API Enhancements:
ProjectsFunction) and service method (GetActiveProjectsAsync) to provide a list of active projects via the/api/projectsendpoint. [1] [2] [3] [4]Frontend Improvements:
Home.razorto load and display active projects in a data grid, allowing users to select a project and generate a report, with improved loading/error handling and UI/UX. [1] [2]Authentication and SPA Routing Configuration:
staticwebapp.config.jsonto include anavigationFallbackwith exclusions for authentication endpoints and Blazor static assets, ensuring correct routing and authentication flows.Documentation Updates:
README.mdand deployment docs to clarify authentication flow, the importance of SPA fallback exclusions, and the configuration of response overrides for unauthenticated users. [1] [2]