Fixed serializing of appearence data when sending mails

MUnique · Jan 19, 2025 · a30e913 · a30e913
1 parent d803424
commit a30e913
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/GameLogic/ItemExtensions.cs b/src/GameLogic/ItemExtensions.cs
@@ -347,14 +347,15 @@ public static ItemAppearance GetAppearance(this Item item)
     /// </summary>
     /// <param name="itemAppearance">The item appearance.</param>
     /// <param name="persistenceContext">The persistence context where the object should be added.</param>
+    /// <param name="gameConfiguration">The game configuration.</param>
     /// <returns>A persistent instance of the given <see cref="ItemAppearance"/>.</returns>
-    public static ItemAppearance MakePersistent(this ItemAppearance itemAppearance, IContext persistenceContext)
+    public static ItemAppearance MakePersistent(this ItemAppearance itemAppearance, IContext persistenceContext, GameConfiguration gameConfiguration)
     {
         var persistent = persistenceContext.CreateNew<ItemAppearance>();
         persistent.ItemSlot = itemAppearance.ItemSlot;
         persistent.Definition = itemAppearance.Definition;
         persistent.Level = itemAppearance.Level;
-        itemAppearance.VisibleOptions.Distinct().ForEach(o => persistent.VisibleOptions.Add(o));
+        itemAppearance.VisibleOptions.Distinct().ForEach(o => persistent.VisibleOptions.Add(gameConfiguration.ItemOptionTypes.First(iot => iot.Equals(o))));
         return persistent;
     }
 

diff --git a/src/GameLogic/PlayerActions/Messenger/LetterSendAction.cs b/src/GameLogic/PlayerActions/Messenger/LetterSendAction.cs
@@ -87,7 +87,7 @@ private LetterHeader CreateLetter(IContext context, Player player, string receiv
         letterBody.Message = message;
         letterBody.SenderAppearance = context.CreateNew<AppearanceData>();
         letterBody.SenderAppearance.CharacterClass = player.AppearanceData.CharacterClass;
-        player.AppearanceData.EquippedItems.Select(i => i.MakePersistent(context)).ForEach(letterBody.SenderAppearance.EquippedItems.Add);
+        player.AppearanceData.EquippedItems.Select(i => i.MakePersistent(context, player.GameContext.Configuration)).ForEach(letterBody.SenderAppearance.EquippedItems.Add);
         letterBody.Rotation = rotation;
         letterBody.Animation = animation;
         return letterHeader;