Skip to content

Bugs and tests#98

Open
DanielWang2029 wants to merge 19 commits into
masterfrom
bugs_and_tests
Open

Bugs and tests#98
DanielWang2029 wants to merge 19 commits into
masterfrom
bugs_and_tests

Conversation

@DanielWang2029
Copy link
Copy Markdown
Collaborator

Added solution for the first issue and updated code for the second issue.

Added dw test
Added codes I wrote to understand test_that and vdiffr
Added svg plot for validation
Changed variable names in test
Added new test file, need to delete old test file
algorithm.r contains a function that returns the arrangment of icons given the canvas size and icon numbers.
Updated algorithm and part of makeContent function
Updated solution for the first issue
@DanielWang2029
Copy link
Copy Markdown
Collaborator Author

Update geom-bloc
Current version of the code works fine locally but there's no makeContent in cmd check.

@xiaoyingpu xiaoyingpu self-requested a review November 10, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants