Fix scissor box handling #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zpiboo
commented
Sep 2, 2025
Zpiboo
commented
- Fix the scissor in 1.21+
- Make it impossible to hover elements from outside their scissor box
(GL's scissor boxes don't work in newer versions :'( )
- Move Renderer2D's scissorStack to version-specific code for older versions, as newer ones already have it built-in along with a scissorContains method. - Take the current scissor into account in the Component::contains method.
Member
Author
|
Would it really be worth it to add it to fabric-1.21.8 if this version is going to be removed anyway? |
Member
|
im going to merge this pr then tonight ill do some version refactoring to clean up the codebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.