Skip to content

Replace boundingBoxSize infoVar with boundingBox #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Exterminate5573 merged 2 commits into from
Dec 15, 2025
Merged

Replace boundingBoxSize infoVar with boundingBox #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de5ff2e
feat: replace boundingBoxSize infoVar with boundingBox
Zpiboo Dec 12, 2025
adad3ea
Merge branch 'master' into feature/bb-infovar
Zpiboo Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions common/src/main/java/io/github/kurrycat/mpkmod/compatibility/MCClasses/Player.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,15 +368,11 @@ public Player getPrevious() {
return tickHistory.get(i - 1);
}

@InfoString.Getter
public BoundingBox3D getBoundingBox() {
return boundingBox;
}

@InfoString.Getter
public Vector3D getBoundingBoxSize() {
return boundingBox.getSize();
}

public Player setBoundingBox(BoundingBox3D boundingBox) {
this.boundingBox = boundingBox;
return this;
Expand All @@ -396,10 +392,6 @@ public BoundingBox3D getLastBoundingBox() {
return getPrevious().getBoundingBox();
}

public Vector3D getLastBoundingBoxSize() {
return getLastBoundingBox().getSize();
}

@InfoString.Getter
public Vector3D getLastPos() {
return lastPos;
Expand Down