Skip to content

Fix ComponentHolder::setWidth setting the component's height #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Exterminate5573 merged 2 commits into from
Sep 7, 2025
Merged

Fix ComponentHolder::setWidth setting the component's height #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a37c1
fix: make ComponentHolder::setWidth change the component's width as e…
Zpiboo Sep 6, 2025
76243b3
remove useless setWidth method in InputField
Zpiboo Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/src/main/java/io/github/kurrycat/mpkmod/gui/components/ComponentHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,9 @@ public void setHeight(double h, boolean percent) {
}

public void setWidth(double w, boolean percent) {
if (this.size.getY() == w && percent == PERCENT.HAS_SIZE_X(percentFlag)) return;
if (this.size.getX() == w && percent == PERCENT.HAS_SIZE_X(percentFlag)) return;
percentFlag = PERCENT.SET_SIZE_X(percentFlag, percent);
this.size.setY(PERCENT.HAS_SIZE_Y(percentFlag) ? MathUtil.constrain01(w) : w);
this.size.setX(PERCENT.HAS_SIZE_X(percentFlag) ? MathUtil.constrain01(w) : w);
updatePosAndSize();
}

Expand Down
4 changes: 0 additions & 4 deletions common/src/main/java/io/github/kurrycat/mpkmod/gui/components/InputField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,6 @@ public void clear() {
content = "";
}

public void setWidth(double width) {
this.size.setX(width);
}

@Override
public boolean handleMouseInput(Mouse.State state, Vector2D mousePos, Mouse.Button button) {
if (button == Mouse.Button.LEFT) {
Expand Down
10 changes: 1 addition & 9 deletions common/src/main/java/io/github/kurrycat/mpkmod/gui/screens/LandingBlockGuiScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,14 +210,6 @@ public int getHeight() {
public void render(int index, Vector2D pos, Vector2D size, Vector2D mouse) {
Renderer2D.drawRectWithEdge(pos, size, 1, lbListColorBg, lbListColorItemEdge);

for (int i = 0; i < fields.length; i++) {
fields[i].setPos(pos.add(
size.getX() / 12 + size.getX() / 5 * 2 * (((int) (i / 3))),
size.getY() / 4 * (1 + (i % 3)) - fields[i].getDisplayedSize().getY() / 2
));
fields[i].setWidth(size.getX() / 3);
}

if (collapsed)
FontRenderer.drawString(
landingBlock.boundingBox.getMin() + " - " + landingBlock.boundingBox.getMax(),
Expand All @@ -234,7 +226,7 @@ public void render(int index, Vector2D pos, Vector2D size, Vector2D mouse) {
size.getX() / 12 + size.getX() / 5 * 2 * (((int) (i / 3))),
size.getY() / 4 * (1 + (i % 3)) - fields[i].getDisplayedSize().getY() / 2
));
fields[i].setWidth(size.getX() / 3);
fields[i].setWidth(size.getX() / 3, false);
fields[i].render(mouse);
}

Expand Down