Skip to content

Fix pre-commit workflow and other CI updates/cleanup#138

Merged
xylar merged 3 commits into
MPAS-Dev:mainfrom
altheaden:fix-clean-ci
Aug 1, 2025
Merged

Fix pre-commit workflow and other CI updates/cleanup#138
xylar merged 3 commits into
MPAS-Dev:mainfrom
altheaden:fix-clean-ci

Conversation

@altheaden

@altheaden altheaden commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

This PR expands on some of the changes made in #136 to add some fixes and updates to various CI workflows. The changes include:

  1. All static (non-matrix) versions of python used in CI have been updated to 3.13
  2. PYTHON_VERSION is now defined in all workflow files for consistency
  3. REVIEWERS variable is now used to list the reviewers instead of a magic string to make things more readable
  4. pre_commit_update_workflow.yml has been fixed to use conda in to avoid a bug with gh which was causing permissions errors in workflow runs
  5. workflow_dispatch has been added to pre_commit_update_workflow.yml CI workflow to allow manual triggering

@xylar Review checklist:

@altheaden
altheaden requested a review from xylar August 1, 2025 18:38
@altheaden altheaden added the ci Changes that affect github actions CI label Aug 1, 2025

@xylar xylar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@xylar
xylar merged commit 702018e into MPAS-Dev:main Aug 1, 2025
6 checks passed
@altheaden
altheaden deleted the fix-clean-ci branch August 1, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes that affect github actions CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants