Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCT: Standalone Motif Combo #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PCT: Standalone Motif Combo #315

wants to merge 1 commit into from

Conversation

RuinIv
Copy link

@RuinIv RuinIv commented Jul 21, 2024

I had opened a PR for this change off of the fork Fenyn had after replying to the PR here, but it looks like the PR got merged in before this could be considered, so I'll reopen it here :)

Per the comment, I think it would be great to support Weapon Motif -> Hammer Stamp / Landscape Motif -> Star Prism as a standalone combo that doesn't rely on you using the Muse combo. The reason for this being, if you use the Muse combo, once you've gone through your combo, you can no longer see the cooldowns of the Muse, since the Motif will be active button until you paint another picture.

One could argue that you could just keep them separately somewhere just to keep track of the cooldowns, but I think that defeats the point of the plugin, and that if someone wants to have it so that the Motifs go into the relative attacks while keeping the Muses separate (such as myself), that it's a valid use case to support.

@attickdoor
Copy link
Collaborator

you will no longer see the cooldown of the Muse

That's why this is on the Motif button instead of the Muse button. You can put the standalone Muse button somewhere else and watch your CD, or use it if you'd like. But I see your point.

@attickdoor
Copy link
Collaborator

attickdoor commented Jul 30, 2024

Upon further thought, one combo shouldn't gatekeep the other, I agree. This will be updated for release (soon ™️)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants