Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR adds two new combos to XIV Combo. These are:
Reasoning
I use XIV Combo primarily to collapse combos without any branching paths or decision points into a single button.
For example, on GNB I use the Solid Barrel combo and the Demon Slaughter combo, as there are no branching paths. But on the Ninja, I only use the Aeolian Edge and Hakke Mujinsatsu combos, and leave Armor Crush as is. This is because it is a branching path for ending the Aeolian Edge combo.
On Samurai, I wanted to have Jinpu -> Gekko and Shifu -> Kasha collapsed into one button because I have already made the choice between which of the three Hakaze follow up combos I want to use. This saves on some button space but keeps the feeling and rhythm of Samurai's combo flow intact.
A huge bonus is not having duplicate icons on my hotbar anymore! I still save a few buttons but don't have to look at 4 Hakazes on my bar at once and not remember which button starts each combo, as each action only exists in one combo chain.
Conclusion
I have been using this modification on my own computer for months now but just now decided to create an actual git commit and PR as I would love if this feature could be in the main project.
Sorry for the really long explanation! I hope you'll consider my addition.