Gabriel edits #23
Open
Gabriel edits #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equationcrunchor
requested changes
Apr 25, 2021
Contributor
equationcrunchor
left a comment
equationcrunchor
left a comment
There was a problem hiding this comment.
You have a mistake where clock.hpp is not in the inc directory, which causes compilation to fail. You also need to make sure the generated files are git ignored.
For some reason, the tests take a long time to run on my laptop. Is it the same for you?
Also, can you check that this compiles with MY20? Need to make sure the arrays aren't too large to fit in memory.
reality95
force-pushed
the
gabriel_edits
branch
from
71ed943 to
fd3ba31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.