Skip to content

Streamline file reading to use io streams #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions wfdb/io/_coreio.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import posixpath
import os

from wfdb.io import _url
from wfdb.io.download import config


def _open_file(
pn_dir,
file_name,
mode="r",
*,
dir_name="",
pn_dir=None,
buffering=-1,
encoding=None,
errors=None,
@@ -24,15 +26,18 @@ def _open_file(
Parameters
----------
pn_dir : str or None
The PhysioNet database directory where the file is stored, or None
if file_name is a local path.
file_name : str
The name of the file, either as a local filesystem path (if
`pn_dir` is None) or a URL path (if `pn_dir` is a string.)
mode : str, optional
The standard I/O mode for the file ("r" by default). If `pn_dir`
is not None, this must be "r", "rt", or "rb".
dir_name : str or None
If passed, and pn_dir is None, the directory will be prepended
to the file_name.
pn_dir : str or None
The PhysioNet database directory where the file is stored, or None
if file_name is a local path.
buffering : int, optional
Buffering policy.
encoding : str, optional
@@ -48,7 +53,7 @@ def _open_file(
"""
if pn_dir is None:
return open(
file_name,
os.path.join(dir_name, file_name),
mode,
buffering=buffering,
encoding=encoding,
Loading