-
Notifications
You must be signed in to change notification settings - Fork 97
Continuum Damage Model #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
+ Coverage 43.61% 43.63% +0.02%
==========================================
Files 66 66
Lines 19748 19835 +87
Branches 2413 2433 +20
==========================================
+ Hits 8613 8655 +42
- Misses 9653 9688 +35
- Partials 1482 1492 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
074a021
to
d1e7fa0
Compare
@ChrisZYJ change this from a draft pr to a regular pr when it's ready for review 👍 |
docs/documentation/case.md
Outdated
| `cont_damage_s` | Real | Power `s` for continuum damage model | | ||
| `alpha_bar` | Real | Damage factor (rate) for continuum damage model | | ||
|
||
- `cont_damage` activates continuum damage model for solid materials. Requires `tau_star`, `cont_damage_s`, and `alpha_bar` to be set (empirically determined) ([Cao et al., 2019](references.md#cao19)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think these work, please see #509
do l = adv_idx%end + 1, sys_size | ||
@:ALLOCATE(q_prim_qp%vf(l)%sf(idwbuff(1)%beg:idwbuff(1)%end, idwbuff(2)%beg:idwbuff(2)%end, idwbuff(3)%beg:idwbuff(3)%end)) | ||
end do | ||
num_eqns_after_adv = count((/surface_tension, cont_damage/)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever 👍
@ChrisZYJ, does this fix all the links? If so, you can add that you fixed GH issue 509, and we will close that via this PR. |
This fixes all the broken links by redirecting them to the reference page instead of to a specific reference on that page. If that's all right, then this PR should be ready for merging |
Description
2-way coupled continuum damage model for elastic simulations.
Also fixes #509 along the way.
Type of change
Scope
How Has This Been Tested?
2WayContDamage.mp4
Checklist
docs/
)examples/
that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh format
before committing my codeIf your code changes any code source files (anything in
src/simulation
)To make sure the code is performing as expected on GPU devices, I have:
nvtx
ranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys
, and have attached the output file (.nsys-rep
) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --omniperf
, and have attached the output file and plain text results to this PR.