Skip to content

Fix #797 #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Fix #797 #813

wants to merge 24 commits into from

Conversation

dgvacarevelo
Copy link
Contributor

Description

Removes 'stop' commands from the GPU regions, and relocate them in CPU regions.

Fixes #797

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

@dgvacarevelo dgvacarevelo requested a review from a team as a code owner April 1, 2025 14:09
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (314c05a) to head (a7c0930).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_bubbles_EL.fpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   43.66%   43.65%   -0.01%     
==========================================
  Files          65       66       +1     
  Lines       19159    19731     +572     
  Branches     2338     2406      +68     
==========================================
+ Hits         8365     8613     +248     
- Misses       9370     9637     +267     
- Partials     1424     1481      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson
Copy link
Member

@dgvacarevelo FYI the Phoenix runner won't work for a day or two, that machine is offline for maintenance.

@sbryngelson sbryngelson marked this pull request as draft April 9, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot have stop in accelerator region
2 participants