test(users): update DELETE test to call /users/:id and assert service…#517
Merged
Qoder-Undefined merged 1 commit intoJun 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #494
Summary
Fix a failing test in the users controller spec by updating the request path to match the controller route. This is a test-only change that makes the spec call DELETE /users/1 and asserts the service invocation.
Changes
Updated test to call /users/1 instead of /users
Added assertion that userService.deleteUser(1) is called
Files
users.controller.spec.ts — updated test
users.controller.ts — unchanged (kept @delete('/:id'))
How to run locally
Test output (targeted run)
PASS src/users/users.controller.spec.ts
Test Suites: 1 passed, 1 total
Tests: 17 passed, 17 total
Acceptance checklist
Test updated to call DELETE /users/:id
Test asserts userService.deleteUser called with parsed id
Targeted spec passes locally
Commit & branch
Commit: test(users): update DELETE test to call /users/:id and assert service call
Branch: fix/users-delete-route-test
Follow-ups
If a DELETE /users (delete-all) endpoint is desired, open a new issue/PR and implement with appropriate authorization and safeguards.
Optionally add response-body assertions for the delete endpoint if the service returns structured output.