feat(upload): implement secure file upload with validation and multi-provider support#507
Merged
Qoder-Undefined merged 1 commit intoJun 21, 2026
Conversation
…provider support - Add strict MIME-type validation via NestJS FileTypeValidator (header level) - Add magic-byte validation in UploadService to prevent MIME-spoofing attacks - Sanitize filenames: strip path traversal, double extensions, and special chars - LocalStorageProvider: safe dir creation (0o755), path-traversal guard on write - S3StorageProvider: real @aws-sdk/client-s3 PutObjectCommand integration, supports explicit credentials or SDK default credential chain - Add upload.config.ts using registerAs() pattern (consistent with jwt.config.ts) - Add shared sanitizeFilename() utility (DRY across both providers) - Add unit tests: 39 tests across 5 suites covering happy paths and edge cases (spoofed MIME, path traversal, double extension, missing config, SDK errors) Closes MERIDIAN-CITY#451
Qoder-Undefined
approved these changes
Jun 21, 2026
Qoder-Undefined
left a comment
Qoder-Undefined
left a comment
Contributor
There was a problem hiding this comment.
LGTM nicely done @dDevAhmed thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451