fix(nav): visual consistency pass on sidebar and guest Home - #3772
fix(nav): visual consistency pass on sidebar and guest Home#3772nachocossio wants to merge 1 commit into
Conversation
Three unrelated visual inconsistencies from PUR-35: - Support/Settings icons in the guest sidebar footer were rendered at 70% opacity while every other icon (nav items above, Sign in below) used full color. Dropped the opacity override. - Sidebar default width (12rem) was too narrow for its own content: "Invite team members" and typical name/email pairs got clipped with an ellipsis. Bumped to 16rem, the design system's usual default. - The shared app header (Sign in / Create account / GitHub star) was unconditionally hidden on the Home tab since "make nux clean" (#2868). That also removed guests' only sign-up affordance there, since it hid the header for guests and signed-in users alike. Now only suppressed for signed-in users, so Home stays clean for them while guests keep a way to sign in / create an account. PUR-35
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe app now keeps the header visible on Home for guests and hides it for signed-in WorkOS users. Playground onboarding still hides the header for all users. Signed-out sidebar utility buttons use full-opacity foreground styling. The desktop sidebar width increases from Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Internal previewPreview URL: https://mcp-inspector-pr-3772.up.railway.app |
Summary
PUR-35 — three unrelated visual inconsistencies flagged by Marcelo:
Fix
mcp-sidebar.tsx: dropped the/70opacity override on the footer utility icons.ui/sidebar.tsx:SIDEBAR_WIDTH12rem → 16rem (this design system's usual default).App.tsx: header is now hidden on Home only when a user is signed in, preserving the clean NUX for them while restoring the sign-in/sign-up affordance for guests.Test plan
vitest runon sidebar/auth suites (36 tests) +App.hosted-oauth.test.tsx(62 tests): all passtsc --noEmiton the client project: no new errors--sidebar-widthnow resolves to16remSummary by cubic
Fixes sidebar and guest Home visual inconsistencies to address PUR-35: consistent icon colors, no label truncation, and restored sign-in/sign-up for guests.
/70opacity).Written for commit 9ca1905. Summary will update on new commits.