Skip to content

fix(nav): visual consistency pass on sidebar and guest Home - #3772

Open
nachocossio wants to merge 1 commit into
mainfrom
fix/pur-35-nav-visual-consistency
Open

fix(nav): visual consistency pass on sidebar and guest Home#3772
nachocossio wants to merge 1 commit into
mainfrom
fix/pur-35-nav-visual-consistency

Conversation

@nachocossio

@nachocossio nachocossio commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

PUR-35 — three unrelated visual inconsistencies flagged by Marcelo:

  1. Icon color mismatch in guest sidebar. Support/Settings icons at the bottom of the signed-out sidebar rendered at 70% opacity while every other icon (nav items above, Sign in below) rendered at full color.
  2. Truncated sidebar labels. Default sidebar width (12rem) was too narrow for its own content — "Invite team members" and typical name/email pairs got clipped with an ellipsis. The sidebar has no drag-to-resize, so the only fix is the default width itself.
  3. Guest Home missing sign-in/sign-up. The shared app header (Sign in / Create account / GitHub star) has been unconditionally hidden on the Home tab since "make nux clean" (make nux clean #2868) — for guests and signed-in users alike. That silently removed guests' only sign-up affordance on the page they land on.

Fix

  • mcp-sidebar.tsx: dropped the /70 opacity override on the footer utility icons.
  • ui/sidebar.tsx: SIDEBAR_WIDTH 12rem → 16rem (this design system's usual default).
  • App.tsx: header is now hidden on Home only when a user is signed in, preserving the clean NUX for them while restoring the sign-in/sign-up affordance for guests.
nav-branch-1-home-expanded nav-branch-2-home-collapsed nav-branch-2-sidebar-expanded nav-branch-3-home-collapsed nav-branch-3-rail-collapsed nav-branch-4-rail-collapsed nav-branch-4-rail-expanded nav-branch-5-servers

Test plan

  • vitest run on sidebar/auth suites (36 tests) + App.hosted-oauth.test.tsx (62 tests): all pass
  • tsc --noEmit on the client project: no new errors
  • Confirmed live in the running dev server that --sidebar-width now resolves to 16rem

Summary by cubic

Fixes sidebar and guest Home visual inconsistencies to address PUR-35: consistent icon colors, no label truncation, and restored sign-in/sign-up for guests.

  • Bug Fixes
    • Guest sidebar footer icons now use full color (removed /70 opacity).
    • Sidebar width increased from 12rem to 16rem to avoid truncated labels.
    • App header on Home is shown for guests and hidden only for signed-in users.

Written for commit 9ca1905. Summary will update on new commits.

Review in cubic

Three unrelated visual inconsistencies from PUR-35:

- Support/Settings icons in the guest sidebar footer were rendered at
  70% opacity while every other icon (nav items above, Sign in below)
  used full color. Dropped the opacity override.

- Sidebar default width (12rem) was too narrow for its own content:
  "Invite team members" and typical name/email pairs got clipped with
  an ellipsis. Bumped to 16rem, the design system's usual default.

- The shared app header (Sign in / Create account / GitHub star) was
  unconditionally hidden on the Home tab since "make nux clean"
  (#2868). That also removed guests' only sign-up affordance there,
  since it hid the header for guests and signed-in users alike. Now
  only suppressed for signed-in users, so Home stays clean for them
  while guests keep a way to sign in / create an account.

PUR-35
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 7, 2026
@chelojimenez

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: acd2b14c-ebcd-410b-b5a7-a45ac5f736ae

📥 Commits

Reviewing files that changed from the base of the PR and between 84afff1 and 9ca1905.

📒 Files selected for processing (3)
  • mcpjam-inspector/client/src/App.tsx
  • mcpjam-inspector/client/src/components/mcp-sidebar.tsx
  • mcpjam-inspector/client/src/components/ui/sidebar.tsx

Walkthrough

The app now keeps the header visible on Home for guests and hides it for signed-in WorkOS users. Playground onboarding still hides the header for all users. Signed-out sidebar utility buttons use full-opacity foreground styling. The desktop sidebar width increases from 12rem to 16rem.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Internal preview

Preview URL: https://mcp-inspector-pr-3772.up.railway.app
Deployed commit: 5c9c251
PR head commit: 9ca1905
Backend target: staging fallback.
Health: ✅ Convex reachable
Access is employee-only in non-production environments.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants