chore: sync harness/ with the kit — the advisory nudge hook - #25
Merged
Conversation
Regenerates the bundled payload from delivery-standard/kit after MCKRUZ/intent-driven-development#34, which added the nudge-hook pattern to the kit's hooks README and shipped sensitive-edit-nudge.{ps1,sh} as its worked example. Without this the plugin installs a README describing a hook the adopter does not have. `sync_kit.py` ran clean (123 files, --check reports in sync), but two things needed a hand afterward and neither is caught by the sync itself: - shutil.copytree does not carry the git executable bit on Windows, so the new .sh landed 100644 while its three siblings are 100755. Installed non-executable it dies with 'Permission denied' — the exact failure install_harness.py warns about. Set with update-index --chmod=+x. Every future .sh added to the kit will need the same, which is worth fixing in sync_kit.py rather than remembering. - The golden installed-tree snapshot caught the two new files, as designed. Regenerated via GOLDEN_REGEN=1; the diff is exactly the two expected paths and nothing else. 531 passed, 6 skipped. Self-approved under the solo-maintainer carve-out: internal repo, no second maintainer, suite green, and named here rather than taken silently. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014aesqvsMqJpzEdpDXDTjvF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the bundled
harness/payload fromdelivery-standard/kitafter intent-driven-development#34, which documented the nudge-hook pattern and shippedsensitive-edit-nudge.{ps1,sh}as its worked example.Without this, the plugin installs a hooks README describing a file the adopter doesn't have.
What the sync produced
scripts/sync_kit.pyran clean — 123 files,--checknow reports in sync. Four paths changed: the two READMEs and the two new hook twins.Two things the sync did not handle
Neither is caught by
sync_kit.py, and both needed a hand:shutil.copytreedoesn't carry the git exec bit on Windows, so the new.shlanded100644while its three siblings are100755. Installed non-executable it dies withPermission denied— the exact failureinstall_harness.py:158warns about. Fixed withupdate-index --chmod=+x. Every future.shadded to the kit will hit this, so it belongs insync_kit.pyrather than in someone's memory. Filing separately.GOLDEN_REGEN=1; the diff is exactly the two expected paths and nothing else.Test plan
python scripts/sync_kit.py --check— in sync, 123 filespytest scripts/tests— 531 passed, 6 skippedharness/hooks/sensitive-edit-nudge.shcommitted100755, matching the other three twinsApproval
Self-approved under the solo-maintainer carve-out in the standard's
docs/team.md: internal repo, no second maintainer, suite green, named here rather than taken silently.🤖 Generated with Claude Code
https://claude.ai/code/session_014aesqvsMqJpzEdpDXDTjvF