Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating node from computation #6

Merged
merged 12 commits into from
Nov 21, 2018

Conversation

artivis
Copy link

@artivis artivis commented May 16, 2017

!! This is a work in progress !!

It aims at separating the node from the main computation hence an attempt at exposing a clear API (#5).

Looking forward for feedback.

@artivis artivis force-pushed the separating_node_computation branch from 31f3651 to be973ca Compare May 16, 2017 10:24
@artivis
Copy link
Author

artivis commented Jun 22, 2017

Now it compiles on a machine with ros Kinetic installed.
There is still some work and a lot of testing to do.
Again looking forward for feedback.

@JGMonroy
Copy link
Member

JGMonroy commented Jun 23, 2017 via email

@artivis artivis force-pushed the separating_node_computation branch from ecf6d08 to 07c9a7b Compare August 12, 2017 16:16
@artivis
Copy link
Author

artivis commented Aug 12, 2017

Hi @JGMonroy ,
I have just rebased this PR on your latest changes.
Things compile and run on my machine with the latest MRPT master.
Will you have time to look at this PR ??

As a recall its main purpose is only to separate the computation (mostly unchanged) from the ros node.
It also aims at providing some kind of an API in order to ease integration of this laser odometry to other projects.

Best.

@artivis artivis changed the title [WIP][Do Not Merge] Separating node from computation Separating node from computation Aug 14, 2017
@JGMonroy JGMonroy merged commit 06301fd into MAPIRlab:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants