Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion calculator.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
function isNumber(numStr){
var re = /^[0-9\.]+$/;
var re = /^[0-9\.\-]+$/;
return re.test(numStr);
}

Expand All @@ -11,5 +11,16 @@ function substract(num1, num2){
return num1 - num2;
}

function multiplication(num1, num2){
return num1 * num2;
}

function division(num1, num2){
return num1 / num2;
}

module.exports.add = add;
module.exports.substract = substract;
module.exports.multiplication = multiplication;
module.exports.division = division;
module.exports.isNumber = isNumber;
2 changes: 2 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ <h1>Silly Calculator</h1>
<select id="operator" size="1">
<option value="add">+</option>
<option value="substract">-</option>
<option value="multiplication">×</option>
<option value="division">÷</option>
</select>
<input type="text" id="num2" value="1" />
<div>=</div>
Expand Down
6 changes: 6 additions & 0 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ window.onload = function(){
else if (operator == "substract"){
document.getElementById('ans').value = substract(num1, num2);
}
else if (operator == "multiplication"){
document.getElementById('ans').value = multiplication(num1, num2);
}
else if (operator == "division"){
document.getElementById('ans').value = division(num1, num2);
}
else {
alert("Bad operator!")
}
Expand Down
16 changes: 15 additions & 1 deletion test/test_calculator.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,21 @@ var cal = require('../calculator.js')
describe('Calculator', function(){
describe('add', function(){
it('add', function(){
assert.equal('2', cal.add(1, 1));
assert.equal('123', cal.add(54, 69));
})
it('substract', function(){
assert.equal('-12', cal.substract(46, 58));
})
it('multiplication', function(){
assert.equal('1036', cal.multiplication(28, 37));
})
it('division', function(){
assert.equal('91', cal.division(1547, 17));
})
})
describe('Unvalid Input', function(){
it('not a number', function(){
assert.equal(false, cal.isNumber('Hello'))
})
})
})