Align MALI/MPAS-Ocean constants with E3SM shared values and unify glacier-ice density defaults#174

Draft

Copilot wants to merge 22 commits into

developfrom

copilot/unify-mali-e3sm-constants

Commits on Apr 8, 2026

Commits on May 5, 2026

Apply suggestions from code review

trhille
and
matthewhoffman
authored
Add shared glacier-ice density defaults for MALI and MPAS-Ocean

Copilot
and
trhille
authored
Clarify and align ideal gas constant conversion in MALI constants

Copilot
and
trhille
authored
Clarify derivations for fallback constants in li_constants

Copilot
and
trhille
authored
Match fallback ideal gas constant to SHR_CONST_RGAS conversion

Copilot
and
trhille
authored
Compute fallback constants from shared-equivalent formulas

Copilot
and
trhille
authored
Mark helper fallback constants private in li_constants

Copilot
and
trhille
authored
Move new glacier-related constants to PCD and switch MALI imports

Copilot
and
trhille
authored
Rename PCD module to pcd_const and align kind usage

Copilot
and
trhille
authored
Polish PCD units/comments and fallback constant wording

Copilot
and
trhille
authored
Finalize PCD unit notation and fallback comment alignment

Copilot
and
trhille
authored
Rename PCD ocean freezing depth constant for clarity

Copilot
and
trhille
authored
Clarify standalone ocean-freezing depth fallback comment

Copilot
and
trhille
authored
Normalize PCD glacier density notation and shr_const comment spacing

Copilot
and
trhille
authored
Refine PCD metadata category and constant descriptions

Copilot
and
trhille
authored
Remove shr_const-to-PCD dependency and tighten PCD module visibility

Copilot
and
trhille
authored
Add documentation notes to pcd_const and pcd.yaml version metadata

Copilot
and
trhille
authored
Simplify standalone depth-coefficient comment wording

Copilot
and
trhille
authored
Restore autogenerated PCD files and stop direct pcd_const usage

Copilot
and
trhille
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align MALI/MPAS-Ocean constants with E3SM shared values and unify glacier-ice density defaults#174

Align MALI/MPAS-Ocean constants with E3SM shared values and unify glacier-ice density defaults#174
Copilot wants to merge 22 commits into
developfrom
copilot/unify-mali-e3sm-constants

Commits on Apr 8, 2026

Initial plan

Align MALI constants with E3SM shared constants

Clarify fallback constant alignment with E3SM shared constants

Commits on May 5, 2026

Apply suggestions from code review

Add shared glacier-ice density defaults for MALI and MPAS-Ocean

Clarify and align ideal gas constant conversion in MALI constants

Clarify derivations for fallback constants in li_constants

Match fallback ideal gas constant to SHR_CONST_RGAS conversion

Compute fallback constants from shared-equivalent formulas

Mark helper fallback constants private in li_constants

Move new glacier-related constants to PCD and switch MALI imports

Rename PCD module to pcd_const and align kind usage

Polish PCD units/comments and fallback constant wording

Finalize PCD unit notation and fallback comment alignment

Rename PCD ocean freezing depth constant for clarity

Clarify standalone ocean-freezing depth fallback comment

Normalize PCD glacier density notation and shr_const comment spacing

Refine PCD metadata category and constant descriptions

Remove shr_const-to-PCD dependency and tighten PCD module visibility

Add documentation notes to pcd_const and pcd.yaml version metadata

Simplify standalone depth-coefficient comment wording

Restore autogenerated PCD files and stop direct pcd_const usage