Skip to content

Fix bug in restarts when using Runge-Kutta time integration #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trhille merged 1 commit into from
Apr 7, 2026
Merged

Fix bug in restarts when using Runge-Kutta time integration #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions components/mpas-albany-landice/src/mode_forward/mpas_li_time_integration_fe_rk.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,13 @@ subroutine li_time_integrator_forwardeuler_rungekutta(domain, err)
call mpas_pool_get_array(geometryPool, 'edgeMask', edgeMask)
call mpas_pool_get_array(geometryPool, 'vertexMask', vertexMask, timeLevel=1)


call mpas_pool_get_array(thermalPool, 'temperature', temperature)
call mpas_pool_get_array(thermalPool, 'waterFrac', waterFrac)

! Calculate masks prior to RK loop, but do not update masks within the loop
! to preserve the accuracy of time integration.
call li_calculate_mask(meshPool, velocityPool, geometryPool, err_tmp)
err = ior(err, err_tmp)
! Save relevant fields before RK loop, to be used in update at the end
temperaturePrev(:,:) = temperature(:,:)
waterFracPrev(:,:) = waterFrac(:,:)
Expand Down Expand Up @@ -399,11 +403,6 @@ subroutine li_time_integrator_forwardeuler_rungekutta(domain, err)
return
endif

! Calculate masks prior to RK loop, but do not update masks within the loop
! to preserve the accuracy of time integration.
call li_calculate_mask(meshPool, velocityPool, geometryPool, err_tmp)
err = ior(err, err_tmp)

! *** Start RK loop ***
do rkStage = 1, nRKstages
call mpas_log_write('beginning rk stage $i of $i', &
Expand Down