Skip to content

Map keypad digits in the polkit dialog when Qt ignores NumLock - #1

Open
MADS0LADEN wants to merge 1 commit into
quattrofrom
fix/polkit-keypad-numlock
Open

Map keypad digits in the polkit dialog when Qt ignores NumLock#1
MADS0LADEN wants to merge 1 commit into
quattrofrom
fix/polkit-keypad-numlock

Conversation

@MADS0LADEN

Copy link
Copy Markdown
Owner

Summary

  • Qt does not read system NumLock at startup (QTBUG-32687), so the polkit PIN/password field treats the numeric keypad as off even when Hyprland reports numLock: true.
  • Keypad digits then arrive as navigation keys (Left, Home, End, …) with KeypadModifier and insert nothing until NumLock is toggled twice.
  • Map those keypad keys back to digits in omarchy.polkit so a PIN can be typed immediately. The plugin id is unchanged.

Same change as omacom#10530

Test plan

  • bash test/shell.d/polkit-test.sh
  • pkexec true with NumLock on: type digits on the numeric keypad without toggling NumLock
  • Confirm a wrong PIN still shakes/fails, and Escape still cancels
  • Confirm the top number row still works as before

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI lite review requested due to automatic review settings September 6, 2026 18:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants