Repository navigation
feat(gallery): add a + menu with upload and create album - #13
Merged
Merged
Conversation
The toolbar's Upload button becomes a + button with a dropdown offering Upload photos and Create album, as in the web UI. Create album asks for a title, creates the album at the top level or inside a regular album wherever the server allows it, and opens it. The plain-text ID Lychee returns is accepted and a busy album lock is retried. Spec impact: adds feature 010 spec, plan, tasks and open questions Q-010-01 to Q-010-03, notes the change in feature 005, and updates the knowledge map and roadmap Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the toolbar's Upload button with a + button, as in Lychee's web UI. It opens a dropdown with Upload photos, which works as before and keeps the upload badge, and Create album.
Create album asks for a title and sends POST Album with the current album as parent, or none on the album list, then opens the new album; the page it came from shows it when the user goes back. It is offered only where the server allows creating, which is edit rights on the parent, so never in smart, tag or person albums; the + shows only when it has something to offer. Empty or overlong titles keep the dialog open with a message, failures reopen it with the typed title and the reason, and a busy album lock (409) is retried up to five times like the web client.
Lychee returns the new album's ID as plain text rather than JSON (the controller returns a bare string); the first build only accepted JSON and reported an error for albums it had created. That is fixed and covered by a test.
UploadButton.vue is replaced by AddButton.vue and removed. 649 Vitest tests. The owner checked it on devices.
Spec impact: adds feature 010 spec, plan, tasks and open questions Q-010-01 to Q-010-03, notes the change in feature 005, and updates the knowledge map and roadmap.
🤖 Generated with Claude Code