luxrays: rename GetConfigDir as GetCacheDir and use XDG_CACHE_HOME according to specifications #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cording to specifications - ~/.config should only be used as a fallback if XDG_CONFIG_HOME isn't set. - ~/.config or XDG_CONFIG_HOME is a config directory, not a cache directory. - the cache directory is XDG_CACHE_HOME, is not set by default and should fallback on ~/.cache. - getenv returns nullptr but boost::filesystem::path doesn't accept nullptr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
GetConfigDirasGetCacheDirand useXDG_CACHE_HOMEaccording to specifications.~/.configshould only be used as a fallback ifXDG_CONFIG_HOMEisn't set.~/.configorXDG_CONFIG_HOMEis a config directory, not a cache directory.XDG_CACHE_HOME, is not set by default and should fallback on~/.cache.getenvreturnsnullptrbutboost::filesystem::pathdoesn't acceptnullptr.This work is courtesy of I ♥ Compute initiative funded by 🇫🇷️ rebatir.fr.