[OpenRC] Proposed changes - To Defer - #63
Open
cyidatweaksonly-dot wants to merge 2 commits into
Open
Conversation
added 2 commits
June 16, 2026 17:22
… crash recovery Add supervised OpenRC babysitter units (lunarwing-pg-<t>-ctr, lunarwing-nanocode-<t>-ctr, lunarwing-pebble-<t>-ctr) that block on 'podman wait' under supervise-daemon, reducing crash recovery latency from ~30 min (self-heal sweep) to ~5s. Key design decisions: - Two-unit model: existing imperative unit keeps health-aware status(); new -ctr babysitter handles liveness supervision only. Clean separation. - Wrapper script (ic/scripts/lunarwing-ctr-babysit) invoked via clean positional args in command_args — avoids the OpenRC whitespace-split argv bug that would silently break 'sh -c "..."' patterns. - start_pre() guards bail if runtime/uid/wrapper are missing — prevents infinite crash-loops from exec failures. - Stop ordering: babysitter stopped BEFORE imperative unit, eliminating the race where supervise-daemon respawns a container we just stopped. - -ctr units filtered from health-openrc.sh discovery (S7) and self-heal's unit_tenant() resolution (D-ctr). Lifecycle wiring: - _register_worker_unit: renders + starts boot-persistent -ctr unit - _deregister_worker_unit: stops + removes -ctr unit (babysitter first) - start/stop/uninstall_tenant_openrc: full OpenRC lifecycle Tests: 247/0 (regression 28 + matrix 128 + chaos 36 + openrc 24 + babysit 31). The babysit suite generates real unit files from the renderers, simulates OpenRC argv-splitting, and includes 4 regression grep guards that catch reintroduction of the broken 'sh -c' pattern. See /opt/data/notes/podman-babysitter-review-pass-2026-06-16.md for the full audit.
Full correctness audit of the OpenRC container babysitter changes, including the critical command_args quoting bug found during review and all subsequent fixes applied in the same session.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my message on IRC for more information. Do not merge yet at this time.