Skip to content

fix(link): ensure disabled links are actually disabled when tab-navigated #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinvenclovas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(link): ensure disabled links are actually disabled when tab-navigated #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/LumexUI/Components/Link/LumexLink.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,21 @@ private IReadOnlyDictionary<string, object> Attributes
{
get
{
var attributes = new Dictionary<string, object>()
var attributes = new Dictionary<string, object>();

// Only add href if not disabled
if( !Disabled )
Copy link
Copy Markdown
Contributor

@desmondinho desmondinho Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think we should keep the href for semantics. Since a link is not navigable, it won't harm anyway

{
attributes["href"] = Href;
}
else
{
["href"] = Href
};
// For disabled links, add accessibility attributes
attributes["tabindex"] = "-1";
attributes["aria-disabled"] = "true";
}

if( External )
if( External && !Disabled )
Copy link
Copy Markdown
Contributor

@desmondinho desmondinho Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I am not sure that Disabled should affect externality. Is there any specific reason to check if a link is disabled here?

{
attributes["target"] = "_blank";
attributes["rel"] = "noopener noreferrer";
Expand Down