Skip to content

Add healthcheck #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateeullahmalik merged 1 commit into from
May 6, 2025
Merged

Add healthcheck #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions p2p/kademlia/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ func (s *DHT) ConfigureBootstrapNodes(ctx context.Context, bootstrapNodes string

// Convert the map to a slice
for _, node := range mapNodes {
node.Port = node.Port + 1
hID, _ := utils.Blake3Hash(node.ID)
node.HashedID = hID
fmt.Println("node adding", node.String(), "hashed id", string(node.HashedID))
Expand Down
106 changes: 56 additions & 50 deletions sdk/task/cascade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,16 @@ import (
"errors"
"fmt"
"strings"
"sync"
"time"

"github.com/LumeraProtocol/supernode/pkg/logtrace"
"github.com/LumeraProtocol/supernode/sdk/adapters/lumera"
"github.com/LumeraProtocol/supernode/sdk/adapters/supernodeservice"
"github.com/LumeraProtocol/supernode/sdk/event"
"github.com/LumeraProtocol/supernode/sdk/net"
"golang.org/x/sync/errgroup"
"google.golang.org/grpc/health/grpc_health_v1"
)

const (
Expand Down Expand Up @@ -90,60 +94,62 @@ func (t *CascadeTask) fetchSupernodes(ctx context.Context, height int64) (lumera
if err != nil {
return nil, fmt.Errorf("fetch supernodes: %w", err)
}
// t.logger.Info(ctx, "Supernodes fetched", "count", len(sns))

// if len(sns) == 0 {
// return nil, errors.New("no supernodes found")
// }

// if len(sns) > 10 {
// sns = sns[:10]
// }

// // Keep only SERVING nodes (done in parallel – keeps latency flat)
// healthy := make(lumera.Supernodes, 0, len(sns))
// eg, ctx := errgroup.WithContext(ctx)
// mu := sync.Mutex{}

// for _, sn := range sns {
// sn := sn
// eg.Go(func() error {
// if t.isServing(ctx, sn) {
// mu.Lock()
// healthy = append(healthy, sn)
// mu.Unlock()
// }
// return nil
// })
// }
// if err := eg.Wait(); err != nil {
// return nil, fmt.Errorf("health-check goroutines: %w", err)
// }

// if len(healthy) == 0 {
// return nil, errors.New("no healthy supernodes found")
// }
// t.logger.Info(ctx, "Healthy supernodes", "count", len(healthy))
t.logger.Info(ctx, "Supernodes fetched", "count", len(sns))

if len(sns) == 0 {
return nil, errors.New("no supernodes found")
}

if len(sns) > 10 {
sns = sns[:10]
}

// Keep only SERVING nodes (done in parallel – keeps latency flat)
healthy := make(lumera.Supernodes, 0, len(sns))
eg, ctx := errgroup.WithContext(ctx)
mu := sync.Mutex{}

for _, sn := range sns {
sn := sn
eg.Go(func() error {
if t.isServing(ctx, sn) {
mu.Lock()
healthy = append(healthy, sn)
mu.Unlock()
}
return nil
})
}
if err := eg.Wait(); err != nil {
return nil, fmt.Errorf("health-check goroutines: %w", err)
}

if len(healthy) == 0 {
return nil, errors.New("no healthy supernodes found")
}
t.logger.Info(ctx, "Healthy supernodes", "count", len(healthy))

return sns, nil
}

// // isServing pings the super-node once with a short timeout.
// func (t *CascadeTask) isServing(parent context.Context, sn lumera.Supernode) bool {
// ctx, cancel := context.WithTimeout(parent, connectionTimeout)
// defer cancel()

// client, err := net.NewClientFactory(ctx, t.logger, nil, net.FactoryConfig{
// LocalCosmosAddress: t.config.Account.LocalCosmosAddress,
// }).CreateClient(ctx, sn)
// if err != nil {
// logtrace
// }
// defer client.Close(ctx)

// resp, err := client.HealthCheck(ctx)
// return err == nil && resp.Status == grpc_health_v1.HealthCheckResponse_SERVING
// }
// isServing pings the super-node once with a short timeout.
func (t *CascadeTask) isServing(parent context.Context, sn lumera.Supernode) bool {
ctx, cancel := context.WithTimeout(parent, connectionTimeout)
defer cancel()

client, err := net.NewClientFactory(ctx, t.logger, t.keyring, net.FactoryConfig{
LocalCosmosAddress: t.config.Account.LocalCosmosAddress,
}).CreateClient(ctx, sn)
if err != nil {
logtrace.Info(ctx, "Failed to create client for supernode", logtrace.Fields{
logtrace.FieldMethod: "isServing"})
return false
}
defer client.Close(ctx)

resp, err := client.HealthCheck(ctx)
return err == nil && resp.Status == grpc_health_v1.HealthCheckResponse_SERVING
}

func (t *CascadeTask) registerWithSupernodes(ctx context.Context, supernodes lumera.Supernodes) error {
factoryCfg := net.FactoryConfig{
Expand Down
2 changes: 0 additions & 2 deletions supernode/services/cascade/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package cascade
import (
"context"
"fmt"
"time"

"github.com/LumeraProtocol/supernode/pkg/logtrace"
)
Expand Down Expand Up @@ -88,7 +87,6 @@ func (task *CascadeRegistrationTask) Register(ctx context.Context, req *Register
}

/* 9. Persist artefacts -------------------------------------------------------- */
time.Sleep(time.Second * 30)
if err := task.storeArtefacts(ctx, rqidResp.RedundantMetadataFiles, encResp.SymbolsDir, fields); err != nil {
return nil, err
}
Expand Down
Loading