Skip to content

Fix fee calculation to always round up #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateeullahmalik merged 1 commit into from
Sep 4, 2025
Merged

Fix fee calculation to always round up #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pkg/lumera/modules/tx/impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package tx
import (
"context"
"fmt"
"math"
"strconv"

"github.com/LumeraProtocol/supernode/v2/pkg/logtrace"
Expand Down Expand Up @@ -225,14 +226,14 @@ func (m *module) CalculateFee(gasAmount uint64, config *TxConfig) string {
denom = DefaultFeeDenom
}

feeAmount := gasPriceF * float64(gasAmount)
// Calculate fee and always round up to meet chain minimums
feeFloat := gasPriceF * float64(gasAmount)
feeInt := uint64(math.Ceil(feeFloat))

// Ensure we have at least 1 unit of fee to meet minimal requirements
if feeAmount < 1 {
feeAmount = 1
}
feeInt = max(feeInt, 1)

return fmt.Sprintf("%.0f%s", feeAmount, denom)
return fmt.Sprintf("%d%s", feeInt, denom)
}

// ProcessTransaction handles the complete flow: simulate, build, sign, and broadcast
Expand Down