implemented p2p ping

[akobrin1]

• CLI: replace custom dispatcher with Cobra command tree

  • Root globals: --config, --grpc_endpoint, --p2p_endpoint, --address
  • Subcommands: health-check, get-status, list, p2p (with ping), completion

• P2P: new command group

  • sncli p2p ping [timeout] (or --timeout)
  • Uses Kademlia P2P endpoint; prints "P2P is alive (host:port)" on success
  • Accepts endpoint from flag --p2p_endpoint or config [supernode].p2p_endpoint

• Config:

  • Default config path moved to ~/.sncli/config.toml (can override with --config or SNCLI_CONFIG_PATH)
  • Add [supernode].p2p_endpoint to config schema
  • Wire CLI flag overrides for grpc_endpoint, p2p_endpoint, address

[Copilot]

Pull Request Overview

This PR refactors the CLI application to use the Cobra command framework and adds P2P ping functionality. The change replaces the custom dispatcher pattern with a structured command tree while introducing new P2P utilities for connecting to Supernode Kademlia endpoints.

• Replaces custom CLI dispatcher with Cobra command structure
• Adds P2P ping command with timeout support and secure connection handling
• Updates configuration system to support P2P endpoints and default to ~/.sncli/config.toml

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
cmd/sncli/main.go	Simplified main function to use Cobra's Execute()
cmd/sncli/cmd/*.go	New Cobra command implementations for root, p2p, ping, list, health-check, and get-status
cmd/sncli/cli/cli.go	Refactored CLI initialization and configuration handling
cmd/sncli/cli/p2p.go	New P2P functionality with secure connection and message encoding/decoding
cmd/sncli/cli/types.go	Updated configuration types to include P2P endpoint
p2p/kademlia/dht.go	Improved address parsing using net/url and net.SplitHostPort
cmd/sncli/go.mod	Updated dependencies to include Cobra and related libraries

Comments suppressed due to low confidence (1)

cmd/sncli/cli/cmd_p2p_ping.go:1

• This validation is redundant since time.ParseDuration already handles negative durations and the check at line 22-24 ensures t is positive when using the default.

package cli

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Remove trailing whitespace after the import statement.

Suggested change

	"encoding/binary"
	"encoding/binary"

[Copilot]

The magic number 2 should be defined with a more descriptive name or include units in the constant name, such as defaultMaxPayloadSizeMB.

Suggested change

	defaultMaxPayloadSize = 2 // MB
	defaultMaxPayloadSizeMB = 2 // MB

[Copilot]

Inconsistent indentation. This line uses spaces while other lines use tabs.

Suggested change

	path = filepath.Clean(path)
	path = filepath.Clean(path)

[Copilot]

Storing passphrases in plain text configuration (PassPlain field) poses a security risk. Consider removing this option or adding a warning comment about the security implications.

Suggested change

	LocalAddress string `toml:"local_address"`
	LocalAddress string `toml:"local_address"`
	// WARNING: Storing passphrases in plain text (PassPlain) is insecure and poses a security risk.
	// Avoid using this field in production environments. Prefer PassFile or PassEnv instead.

[Copilot]

The condition len(service) == 0 is redundant since service == \"\" already covers empty strings.

Suggested change

	if len(service) == 0 || service == "" {
	if service == "" {